Extract rule: template-no-aria-hidden-body#2404
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Feb 20, 2026
Merged
Conversation
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-aria-hidden-body
branch
from
339417c to
737f57d
Compare
kategengler
reviewed
Feb 19, 2026
|
|
||
| <!-- end auto-generated rule header --> | ||
|
|
||
| ✅ The `extends: 'recommended'` property in a configuration file enables this rule. |
Contributor
Author
There was a problem hiding this comment.
the linting on this repo is suppose to handle lines like this
Member
There was a problem hiding this comment.
Maybe it handles it if it is above <!-- end auto-generated rule header -->?
| parserOptions: { ecmaVersion: 2022, sourceType: 'module' }, | ||
| }); | ||
|
|
||
| ruleTester.run('template-no-aria-hidden-body', rule, { |
Member
There was a problem hiding this comment.
Should there be tests for fixing?
Contributor
Author
There was a problem hiding this comment.
the one invalid test is that
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-aria-hidden-body
branch
from
737f57d to
33921c6
Compare
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-aria-hidden-body
branch
from
33921c6 to
28526f4
Compare
kategengler
approved these changes
Feb 20, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.